Repository navigation
Report where each tab keeps its project as a user property - #1438
Merged
Merged
Conversation
The session-storage fallback costs code and test surface, and we do not know how many sessions use it. project_storage says whether a tab is on the projects database, on the fallback because the browser has no IndexedDB, on the fallback because the database would not open, or in iframe controller mode where the embedding page keeps the project.
|
Preview build will be at |
Collaborator
Author
|
I created the user-scoped dimension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session-storage fallback costs code and test surface, and we do not know how many sessions use it. This adds a
project_storageuser property so we can decide whether to keep it.databasesession_no_indexeddbindexedDB.session_open_failedhostThe first three are set in
openProjectsDatabase.hostis set at boot inApp.tsx, as iframe mode never opens the database.session_open_failedcovers both a database from a newer version of the editor and any other open failure. Other failures already go to the error log, so they are not split here.For manual follow-up
project_storageas a user-scoped custom dimension in GA4, or it will not appear in reports.page_viewof a visit does not carry it.